OCS Import - Ignored Software NOT recognized

robert.sommer

Dears,

When importing Linux hosts using OCS Import method I was recognizing that Ignored Software Items - defined in OCS Inventory NG Server Web Frontend (/ocsreports) - still result in Application Objects and Software assignments in i-doIT.
From my point of view the following addition at /var/www/idoit/src/classes/components/isys_component_dao_ocs.class.php would fix this issue.

In fact AND softwares.NAME not in (select dico_ignored.EXTRACTED from dico_ignored) is doing the trick.


public function getSoftware($p_hardwareID, $p_snmp = false) {
            if ($p_snmp)
            {
                        $l_query = "SELECT * FROM snmp_softwares WHERE SNMP_ID = " . $this->convert_sql_id($p_hardwareID);
            }
            else
            {
                        $l_query = "SELECT * FROM hardware " . "INNER JOIN softwares ON softwares.HARDWARE_ID = hardware.ID AND softwares.NAME != '' AND softwares.NAME not in (select dico_ignored.EXTRACTED from dico_ignored) " . "WHERE hardware.ID = " . $this->convert_sql_id(
                                                $p_hardwareID
                                    ) . " AND hardware.OSNAME != softwares.NAME";
            } // if

            return $this->retrieve($l_query); }

/**
* Get all applications only from hardware
*
* @return isys_component_dao_result
*/
public function getAllSoftware()
{
            $l_query = "SELECT DISTINCT(softwares.NAME) FROM softwares " . "LEFT JOIN hardware ON hardware.OSNAME = softwares.NAME " . "WHERE hardware.OSNAME IS NULL AND softwares.NAME not in (select dico_ignored.EXTRACTED from dico_ignored)";

            return $this->retrieve($l_query); }

I would really appreciate if you could fix this soon.

Best Regards
Robert

dkirsten

Thanks,

just as I wrote in the other thread, it's implemented in 1.8.3.